Lubuntu/lubuntu-update
3
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

"Packages to be held back" is still shown #2

Closed
tsimonq2 wants to merge 3 commits from tsimonq2/null-packages-fix into ubuntu/noble
pull from: tsimonq2/null-packages-fix
merge into: Lubuntu:ubuntu/noble
Conversation 3 Commits 3 Files Changed 1 +9 -4
tsimonq2 commented 2024-01-25 19:58:38 +00:00
Member
Copy Link

image

and other code sanity tidbits

![image](/attachments/1e705c36-fd27-408e-b16c-ef770a91bdf7) and other code sanity tidbits
image.png
28 KiB
arraybolt3 was assigned by tsimonq2 2024-01-25 19:58:38 +00:00
tsimonq2 added 3 commits 2024-01-25 19:58:39 +00:00 
It is slightly more resource efficient to create a local bool, update that one-way flag when needed, and then setEnabled based on the content of that bool, than it would be to call that method every time.
It's just a little cleaner to read this way
arraybolt3 commented 2024-01-26 04:33:54 +00:00
Member
Copy Link

I may simply be blind or tired, but I can't figure out how any of these changes actually fix the highlighted issue. I'm +1 on all the changes, but did something possibly get missed here?

edit: Nevermind, I am blind. Just figured it out.

I may simply be blind or tired, but I can't figure out how any of these changes actually fix the highlighted issue. I'm +1 on all the changes, but did something possibly get missed here? edit: Nevermind, I am blind. Just figured it out.
arraybolt3 commented 2024-01-26 04:35:21 +00:00
Member
Copy Link

ok, well, +1 on most of the changes - you left a setEnabled call in commit 8cebb36a9c that you probably intended to remove :) but I get the idea of what you were doing there and can add it in.

ok, well, +1 on *most* of the changes - you left a setEnabled call in commit 8cebb36a9c that you probably intended to remove :) but I get the idea of what you were doing there and can add it in.
arraybolt3 commented 2024-01-26 22:11:35 +00:00
Member
Copy Link

Manually merged everything. Thanks!

Manually merged everything. Thanks!
arraybolt3 closed this pull request 2024-01-26 22:11:35 +00:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
meta
A non issue but something related to the project such as a discussion on a feature.
question
More information is needed
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees arraybolt3
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Lubuntu/lubuntu-update#2
No description provided.
Delete Branch "tsimonq2/null-packages-fix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?