Summary: Updated the unit tests to account for recent changes and correct failed tests
Test Plan: run pytest
Reviewers: tsimonq2
Reviewed By: tsimonq2
Differential Revision: https://phab.lubuntu.me/D8
* Significant refactoring: lugito wrapped into a class with common methods, IRC
and Launchpad communications separated as connectors with a separate webhook
module.
* Some unit-tests added
* Added functionality for ircbot to respond to diff links and info as well as
extracting anchor links from tasks / diffs e.g. D15#167
* Built into a python package structure
Still Requires:
* Improved test coverage
* Package documentation
* Additional functionality for other phabricator apps
- Missing .gitignore. Add it.
- Missing requirements.txt, required. Added.
- lugito.py:
- Missing http.client, `import http` isn't enough for that. Import
it.
- Spaces around concatenation `+` and such. Spaces between defs.
PEP8 style.
- Simplify `if` and logicals. Simplify loops.
- Stop using deprecated commands per deprecation warnings.
- Don't shadow other higher-up inherited variables such as 'hash'.
- Declare variables that are 'always' referred to, to avoid problems.
- Use regex instead of re, per Python 3 API recommendations to use
'regex' instead of 're'.
Summary: Convert Lugito to use the logging library rather than print statements.
Test Plan: I tested the bot with a random freenode channel - it works without any issues.
Differential Revision: https://phab.lubuntu.me/D2
Summary: Bot now connects to the IRC server only once, responds to ping requests, and reconnects in case of failure.
Test Plan: Test in prod
Reviewers: tsimonq2
Reviewed By: tsimonq2
Subscribers: tsimonq2
Differential Revision: https://phab.lubuntu.me/D1
Thomas Ward
Ben Johnston
Simon Quigley
Thomas Ward
Konrad Krawiec