Get rid of the last remaining use of subprocess.Popen(shell=True) in

404main.
This commit is contained in:
Colin Watson 2009-06-09 11:00:55 +01:00
parent 6730937ea3
commit ac53f8f767
2 changed files with 3 additions and 1 deletions

View File

@ -123,7 +123,7 @@ def main():
print 'Remember that for 404main to work with a certain distribution it must be in your /etc/apt/sources.list file.'
sys.exit(1)
else:
distro = subprocess.Popen('lsb_release -cs', shell=True, stdout=subprocess.PIPE).stdout.read().strip('\n')
distro = subprocess.Popen(['lsb_release', '-cs'], stdout=subprocess.PIPE).stdout.read().strip('\n')
if not get_package_version(cache, distro, sys.argv[1]):
print 'Can\'t find package «%s» in distribution «%s».' % (sys.argv[1], distro)

2
debian/changelog vendored
View File

@ -38,6 +38,8 @@ ubuntu-dev-tools (0.75) UNRELEASED; urgency=low
[ Colin Watson ]
* Rewrite 404main using python-apt. Note that this requires python-apt
0.7.9, not in jaunty.
* Get rid of the last remaining use of subprocess.Popen(shell=True) in
404main.
-- Michael Bienia <geser@ubuntu.com> Tue, 09 Jun 2009 10:31:03 +0200