Summary:
* Updated automirror.conf
* Removed useless configs
* Added URL for the country code
* Refactored main.py
* Added dictionary with the subdomains of some countries
* Simplified logic
* Removed premature optimizations
* Renamed variables and methods
Test Plan: Compare this version with the previous version. The behaviour is expected to be the same.
Reviewers: tsimonq2, wxl
Differential Revision: https://phab.lubuntu.me/D49
Summary: Adding one line fix to only import socket
Test Plan: Will test in isolated instance of main.py to ensure function
Reviewers: wxl, tsimonq2
Reviewed By: tsimonq2
Differential Revision: https://phab.lubuntu.me/D47
Summary: Updated automirror for urllib.request
Test Plan:
Verify basic function in US, but then also have non-US users test for functionality, especially paying attention to time.
More specifically, this patch should be able to be applied directly to /usr/lib/(i138-linux-gnu|x86_64-linux-gnu)/calamares/modules/automirror/main.py in a live system, then run the installer and see what happens.
Reviewers: tsimonq2, wxl
Reviewed By: tsimonq2
Differential Revision: https://phab.lubuntu.me/D23
Summary: Fixes T82.
Test Plan: Install and reboot. Desktop should be free of the install .desktop file. This has been tested already for EFI and BIOS in a virtual machine, but since this is related to a task that concerns a rather particular system consisting of 32 bit EFI with a 64 bit processor, it will need to be tested in other cases.
Reviewers: tsimonq2
Reviewed By: tsimonq2
Maniphest Tasks: T82
Differential Revision: https://phab.lubuntu.me/D30
Summary: All settings required to enable support for LUKS/encryption.
Test Plan:
The two methods of encryption will need to be tested:
1. Automated option, e.g. Erase Disk
1. Click the radio button for the option
1. Check the Encrypt checkbox
1. Enter your password twice
1. Continue with the install as normal
1. Manual partitioning
1. Create a new partition
1. Check the Encrypt checkbox underneath filesystem
1. Enter your password twice
1. Don't forget to mount as /
1. Continue with the install as normal
If the install completes without errors and can boot successfully after completion, asking for and accepting the correct password before booting the system, then we've got ourselves a winner.
Reviewers: tsimonq2
Reviewed By: tsimonq2
Differential Revision: https://phab.lubuntu.me/D28
Summary:
We were using password checking in Calamares, especially as supported by libpwquality, but have received overwhelming community feedback against this. Therefore, we remove any checking by libpwquality, including defaults that aren't explicit, like the dictionary check. Sadly, it seems that setting enforcing=0 to simply print a warning does not work. IIt's possible that this is a bug, but not worth chasing at this point. The only thing unsupported is a blank password, but that's something that's [not clear](https://github.com/calamares/calamares/issues/790#issuecomment-330455711) is supported.
The good news is that the [string](743c19d8dd/src/modules/users/page_usersetup.ui (L440)) suggesting a good password is still there. If there's anywhere to be additional improments, it's there.
Test Plan: Run Calamares and enter a variety of lame passwords (e.g. space, the number one, the letter a, the word cat, etc.) twice. If the "next" button is not greyed out, it succeeds.
Reviewers: tsimonq2
Reviewed By: tsimonq2
Differential Revision: https://phab.lubuntu.me/D12
Summary: See {T55}
Test Plan:
Install with autologin enabled. After install and reboot, should be in Lubuntu session.
NOTE: an additional fix to calamares itself is required.
Reviewers: tsimonq2
Reviewed By: tsimonq2
Differential Revision: https://phab.lubuntu.me/D9
Simon Quigley
apt-ghetto
Samuel Banya
Walter Lapchynski
Wendy Hill
Lugito
Hans P. Möller
Carl Schwan
Emanuele Antonio Faraone